hirosystems / stacks-blockchain-api

API for the Stacks blockchain
https://stacks-blockchain-api.vercel.app
GNU General Public License v3.0
170 stars 108 forks source link

Revoked BNS Names resolves #1502

Closed dartman10 closed 1 year ago

dartman10 commented 1 year ago

Get Names Owned by Address endpoint still resolves revoked BNS names. I'm thinking revoked BNS names should no longer resolved.

https://stacks-node-api.mainnet.stacks.co/v1/names/101-test-a-0002.stx

2

https://stacks-node-api.mainnet.stacks.co/v1/addresses/stacks/SP38QTNQXVK68A98PSYVY5G28WDNF188H8P0Q0256

1
dartman10 commented 1 year ago

For additional info, using the Explorer, the BNS functions properly identify the revoked name:

Screen Shot 2022-12-25 at 10 43 29 PM Screen Shot 2022-12-25 at 10 45 10 PM Screen Shot 2022-12-25 at 10 45 50 PM Screen Shot 2022-12-25 at 10 46 28 PM
zone117x commented 1 year ago

@rafaelcr any idea if revoked status is supposed to be working right now?

rafaelcr commented 1 year ago

Nice find, @dartman10. I think this is indeed a bug and the API has never treated revoked names correctly.

What would the correct behavior be here @zone117x ? Should we simply stop resolving these names? Or is the last owner's info or revoke last_txid info relevant somehow?

rafaelcr commented 1 year ago

Just confirmed with the blockchain team that these names should stop resolving. I'll implement this fix.

dartman10 commented 1 year ago

Thank you @rafaelcr ! :)

blockstack-devops commented 1 year ago

:tada: This issue has been resolved in version 6.3.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

dartman10 commented 1 year ago

@rafaelcr @zone117x - hi there! Thank you both for the release! 🙏 May I ask how to confirm the result?

Both 101-test-a-0002.stx and thx_dartman007.btc were revoked. However, each still shows up under their respective addresses: https://stacks-node-api.mainnet.stacks.co/v1/addresses/stacks/SP38QTNQXVK68A98PSYVY5G28WDNF188H8P0Q0256 https://stacks-node-api.mainnet.stacks.co/v1/addresses/stacks/SP2FBVA0ACPZDNCHR8Q7Z91S0C28RYGS3K7W835B2

Thanks!

rafaelcr commented 1 year ago

Hi @dartman10 , we still need to update our production deployments to reflect API v6.3.1 so this change is live. I'll try to get that going ASAP.

blockstack-devops commented 1 year ago

:tada: This issue has been resolved in version 7.0.0-beta.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: