search

hirosystems / stacks-blockchain-api

API for the Stacks blockchain
https://stacks-blockchain-api.vercel.app
GNU General Public License v3.0
170 stars 108 forks source link

block endpoint returns `microblocks_streamed` in reverse order #1524

Closed rafaelcr closed 1 year ago

rafaelcr commented 1 year ago 
curl "https://stacks-node-api.testnet.stacks.co/extended/v1/block/by_height/94100"
  "microblocks_streamed": [
    "0x5b5e4236a7496571b56c4765570b9c263f5b529c9b1fa060abf4b6cd50e16c3c",
    "0xfc0a2cf78134a059ceab45f015bc8d797b166c34cb020173c457edff42886c65",
    "0x6776c0009efd73b568e4a842a28cd532d6496eaa023696c1861eeeaf7c1bdf40",
    "0x35e23b5b09cd9c6cdefedb7384462fe33a9e1c92a94ae4530d1ac900a22cf046",
    "0x22f78e21ae15b2eb7dfdf8f6ec542930e4854ce49b2683c4ccb849478931d050",
    "0x5fef449e550cfa48088dfef1c8017164f980d162751dfb4b0a9884a33aabb129"
  ],
sulemanqaiser97 commented 1 year ago

hi @rafaelcr. I've just created a pull request to fix an issue with the microblocks_streamed field being returned in reverse order in the block endpoint. I've made the necessary changes and I would really appreciate it if you could take a look at it.

Unfortunately, I couldn't add you as a reviewer from the PR page, could you please help me on that? The link to the pull request is [https://github.com/hirosystems/stacks-blockchain-api/pull/1528].

Thanks for your time and help!

rafaelcr commented 1 year ago

That's great, thank you @sulemanqaiser97 🤝 I'll take a look