hirosystems / stacks-subnets

Stacks Subnets: a layer-2 scaling solution for Stacks, intended for high-throughput, low-latency workloads
http://docs.hiro.so
GNU General Public License v3.0
52 stars 13 forks source link

feat: add block height to `commit-block` event #260

Closed obycode closed 1 year ago

obycode commented 1 year ago

The event generated by a commit-block (on the L1) now includes the block height for the block that is being committed, in the block-height key of the event tuple. The target burnchain block height now uses the key target-burn-block-height. This is useful for debugging, making it easy to match the L1 transactions with the L2 blocks. Note that this field is not checked in the tests since it is purely for convenience and could be left out of some implementations.

codecov[bot] commented 1 year ago

Codecov Report

Merging #260 (5002792) into master (7d373f0) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   93.47%   93.49%   +0.01%     
==========================================
  Files           6        6              
  Lines         337      338       +1     
==========================================
+ Hits          315      316       +1     
  Misses         22       22              
Impacted Files Coverage Δ
core-contracts/contracts/multi-miner.clar 97.05% <100.00%> (ø)
core-contracts/contracts/subnet.clar 96.52% <100.00%> (+0.01%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

obycode commented 1 year ago

The last force push fixed the failing test. I'll merge once the tests all pass with this latest version.