hirosystems / stacks-subnets

Stacks Subnets: a layer-2 scaling solution for Stacks, intended for high-throughput, low-latency workloads
http://docs.hiro.so
GNU General Public License v3.0
51 stars 13 forks source link

ci: Add explicit `!= ''` comparisons to test if strings are non-empty #262

Closed jbencin closed 1 year ago

jbencin commented 1 year ago

Description

Fixes the docker push step of CI by explicitly checking if a string is empty using !=, rather than relying on an implicit cast

Additional info (benefits, drawbacks, caveats)

This fixes an issue introduced by #258. If you check here, when I made these changes they worked fine. I'm not sure what changed since them to make it fail now.

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #262 (1729198) into master (3a0ef04) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files           6        6           
  Lines         338      338           
=======================================
  Hits          316      316           
  Misses         22       22           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.