hirosystems / stacks-subnets

Stacks Subnets: a layer-2 scaling solution for Stacks, intended for high-throughput, low-latency workloads
http://docs.hiro.so
GNU General Public License v3.0
51 stars 13 forks source link

Ci/improvements #292

Closed CharlieC3 closed 1 year ago

CharlieC3 commented 1 year ago

Closes https://github.com/hirosystems/devops/issues/1235

codecov[bot] commented 1 year ago

Codecov Report

Merging #292 (6f5be11) into master (1f7a824) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   86.53%   86.53%           
=======================================
  Files           6        6           
  Lines         349      349           
  Branches       72       72           
=======================================
  Hits          302      302           
  Misses         47       47           
obycode commented 1 year ago

This will auto-generate changelog entries, right? That's the only thing I don't love, because even if we try to be good about our commit message, those usually still need some manual editing.

CharlieC3 commented 1 year ago

@obycode Yes unless I change it, this current config will generate/update the CHANGELOG.md for each release. You can optionally update it after the release; you might find that to be easier than creating your own from scratch and remembering to update it before merging to master. But if you'd prefer to just remove that part, it's easy to do that while keeping the other features, it would just involve removing these two lines (1 | 2). The Semantic Release plugin lets you choose the features a la carte style.

obycode commented 1 year ago

Sounds good. Let's leave it for now and see how it goes.

jbencin commented 1 year ago

This will auto-generate changelog entries

We've been letting GitHub do this for our last few releases anyway

blockstack-devops commented 1 year ago

:tada: This PR is included in version 0.6.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: