search

hirosystems / stacks-subnets

Stacks Subnets: a layer-2 scaling solution for Stacks, intended for high-throughput, low-latency workloads
http://docs.hiro.so
GNU General Public License v3.0
52 stars 13 forks source link

CI job `compute-layer-1-tests` reports success on failure #309

Closed jbencin closed 1 year ago

jbencin commented 1 year ago

Describe the bug

The problem is a result of the command being a pipeline of 3 different commands:

cargo test --workspace --bin=subnet-node -- l --list --format=terse | sed -e 's/: test//g' | jq -ncR '{"test-name": [inputs]}' > test_names.json

The exit status of the entire pipeline will be the exit status of the last command, so if cargo test fails, but jq does not, the shell will consider the pipeline to have succeeded

Steps To Reproduce

Run a CI job where cargo test fails to build

Additional context

In Bash scripts this can be avoided by adding the line set -o pipefail. I am not sure if Bash is the default /bin/sh invoked by GitHub actions though

blockstack-devops commented 1 year ago

:tada: This issue has been resolved in version 0.8.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: