search

hirosystems / stacks.js

JavaScript libraries for identity, auth, storage and transactions on the Stacks blockchain.
https://stacks.js.org
MIT License
952 stars 309 forks source link

Move wallet specific methods from transaction package to wallet-sdk #1188

Open saralab opened 2 years ago

saralab commented 2 years ago

To better align with Single Responsibility principle, move wallet specific methods from transaction package to wallet-sdk . Ex: address from privKey

kyranjamie commented 2 years ago

This is a good idea, though in the example provided, consider that wallet-sdk depends on some pretty heavy libraries, and we might want to avoid a transaction <--> wallet-sdk dependency.