hirosystems / stacks.js

JavaScript libraries for identity, auth, storage and transactions on the Stacks blockchain.
https://stacks.js.org
MIT License
949 stars 309 forks source link

[1] feat!: stacksjs refactor #1622

Closed janniks closed 7 months ago

janniks commented 8 months ago

EPIC 🏰 Breaking Refactoring Stacks.js

Goal: Make network/networking more obvious and less confusing for developers. While the default code will stay largely the same for most users, it should become more clear what node URL, and fetch implementation is used when.

291331642-81426bac-a6b0-4273-8c37-f92f4c8d8db6

Supersedes https://github.com/hirosystems/stacks.js/pull/1596

@ Reviewers: ✨ Please feel free to leave any feedback on these PRs. Going over the code will show what it's like to code in the new style. So any ideas and feedback (especially negative) is welcome 🙏


This PR:


Split into multiple PRs for easier reviewing

next     ↑ feat/next-cleanup-common-files this PR 🟢     ↑ feat/next-add-new-network #1623     ↑ feat/next-add-api-package #1624     ↑ feat/next-update-api-stacking #1625     ↑ feat/next-update-cli #1626

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ❌ Failed (Inspect) Feb 5, 2024 3:40pm
hugocaillard commented 7 months ago

@janniks So this PR is a small set of changes and is mostly just refactoring with almost no impact for developers right?

janniks commented 7 months ago

Yes mostly small refactoring, however there are breaking changes with many consequences in the chain of PRs. I tried to split them up for easier review and following the refactor. Feel free to take a look at the other PRs mentioned in the description, some will be more breaking than others, but follow the same narrative.