search

hirosystems / stacks.js

JavaScript libraries for identity, auth, storage and transactions on the Stacks blockchain.
https://stacks.js.org
MIT License
944 stars 307 forks source link

fix: resolve circular dependencies #1659

Closed friedger closed 3 months ago

friedger commented 3 months ago

This PR was published to npm with the version 6.12.1-pr.2cf6997.0 e.g. npm install @stacks/common@6.12.1-pr.2cf6997.0 --save-exact

Description

There are circular dependencies between keys and structured data signature file. StructuredDataSignature was moved to common.ts

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview Mar 16, 2024 9:51pm
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.31%. Comparing base (7a11d0b) to head (2cf6997). Report is 23 commits behind head on feat/update-stacking-client-to-pox-4.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/update-stacking-client-to-pox-4 #1659 +/- ## ======================================================================== - Coverage 66.39% 66.31% -0.08% ======================================================================== Files 119 119 Lines 8718 8763 +45 Branches 1920 1953 +33 ======================================================================== + Hits 5788 5811 +23 + Misses 2805 2708 -97 - Partials 125 244 +119 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AshtonStephens commented 3 months ago

@janniks @beguene, this is needed to add changes to lockstacks that are needed for Stacks Testnet release Signer setup. We're aiming to have the dependent ticket merged later today. Can this get eyes sooner than later?

janniks commented 3 months ago

Thanks for the PR, had one open fixing this #1658 merged now 🙏