search

hirosystems / stacks.js

JavaScript libraries for identity, auth, storage and transactions on the Stacks blockchain.
https://stacks.js.org
MIT License
944 stars 307 forks source link

new bufferCV bug #1664

Closed SatoshiNakam closed 3 months ago

SatoshiNakam commented 3 months ago

What version of Stacks.js are you using?

latest

Describe the bug

In bufferCV.ts, buffer.length > 1_000_000 should be buffer.length > 1_048_576.

How to reproduce

Let buffer contains (1_000_000, 1_048_576) characters, bufferCV will trigger error.

Expected behavior

Pls fix it.

janniks commented 3 months ago

Thanks for the report 🙏