Closed obycode closed 2 months ago
🙏🏻 We typically have an IntegerType for this where was it missing?
Oh, nice. I see that now. I was getting an error from signPoxSignature
. It looks like just the period and reward cycle were the problem. Maybe that's intentional though?
Yeah, those we left as number
intentionally, but maybe there's a case they should be bigint
.
I'll close for now, please reopen if you feel bigint
would be better. Realistically it should never be reached/needed, so I hope number
is more understandable to be a lower "number" in users' minds -- but who knows :)
Problem
For all of the functions that take in values that represent Clarity
int
s anduint
s, they should probably acceptbigint | number
, since these types can be larger than anumber
(128-bit vs 64-bit).Solution
Update the parameter types to be
bigint | number
.Additional context