hirschan / Dark-Mode-Wikipedia

A Firefox extension, primarily suited for the English Wikipedia site.
https://addons.mozilla.org/firefox/addon/dark-mode-for-wikipedia/
MIT License
39 stars 8 forks source link

Some pages get almost covered in black #10

Closed sorenss closed 2 years ago

sorenss commented 2 years ago

Very happy that there's only one plugin now! But I am experiencing that certain pages get "covered" in black. It means that most of what's on the screen simply turns black (a few splitseconds after the page has loaded). It corresponds to what is in the image, so that if I scroll down, anything outside the screen is visible, but the search icon and the text just above it (login and the like) is available. The mouse still detects links and other clickable elements even though they are not visible in the black void.

It happens after I have edited a page, and on various pages that are not ordinary articles in non-English Wikipedias (e.g. (https://da.wikipedia.org/wiki/Hj%C3%A6lp:Velkommen_til_Wikipedia]) )

hirschan commented 2 years ago

Thank you for your feedback and discovery!

I am not sure if I understand correctly - certain pages gets covered in black for a few split seconds? When you say image, do you mean the Wikipedia image (the one I attached below)? wikipedia_image

Right now, the extension is based for English Wikipedia (en.wikipedia) and it is not optimal for the editing pages right now. Do you have any screenshots that demonstrates what you mean?

Tack på förhand :-)

sorenss commented 2 years ago

It's after a split second and it keeps staying. I think my "image" should have been "screen". The Wikipedia logo disappears completely. But here's a screenshot:

image

But if I scroll down, anything below the "top screen" (I'm not completely sure what to call it) is visible. Screenshot of the same page as above but scrolled a bit down:

image

It's minor but very weird. When it happens after editing, I can just reload. I have a feeling it did happen on some special pages, but can't find them now. I will return if I figure out if I remember right.

hirschan commented 2 years ago

I tried following and got the same issue as you:

Edit a page -> publish the page -> top screen is black/invisible

If you refresh the page it disappears, but this is quite a weird bug I must say. I will try to look into it, I literally have no idea why it happens.

hirschan commented 2 years ago

I tried YtaloWill's dark mode extension and the same issue occurs. Seems to be an issue when you have a CSS extension.

sorenss commented 2 years ago

Oh well. But thanks for looking into it. Let me know if there's more I can do

hirschan commented 2 years ago

I believe I identified the problem: it is the div element. I might have a workaround, will update these coming days.

sorenss commented 2 years ago

Sorry for my delay. I use it on both Windows and Linux, but I can confirm that it has been fixed now! Thank you very much!