search

hirschan / Dark-Mode-Wikipedia

A Firefox extension, primarily suited for the English Wikipedia site.
https://addons.mozilla.org/firefox/addon/dark-mode-for-wikipedia/
MIT License
39 stars 8 forks source link

Feature suggestion: quick search #18

Closed hirschan closed 2 years ago

hirschan commented 2 years ago

I have thought about a feature pleasant for us who use Wikipedia on a daily basis. Instead of opening a Wikipedia browser and manually search you can now right-click on highlighted text and open in a new Wikipedia tab instantly.

Demonstration: right-clicked

Right now it only works on the Wikipedia domain (://*.wikipedia.org/*) but I want to expand it for all websites ("http://*/*", "https://*/*"). For example, let's say you are browsing a news website and you want to highlight a specific term or word(s) to search for on Wikipedia.

I will publish a PR later. Any thoughts, suggestions or improvements about this @Draeggon, @Mounster-Chef, @jjderooy? I hope you are fine with being tagged and slightly involved in this project, otherwise let me know 😄

jjderooy commented 2 years ago

I would definitely use that feature so if it can be implemented and works reliably enough I say go for.

hirschan commented 2 years ago

Still researching about it, right now it only works for Wikipedia domain or all domains (this applies to the css as well). The issue is the manifest.json file and its declaration of domains to apply to. In worst case I'll have to create a separate extension for this specific feature suggestion.

hirschan commented 2 years ago

Solved, will update on Firefox soon.