search

hirschan / Dark-Mode-Wikipedia

A Firefox extension, primarily suited for the English Wikipedia site.
https://addons.mozilla.org/firefox/addon/dark-mode-for-wikipedia/
MIT License
39 stars 8 forks source link

UI: Unreadable tables #21

Open megagrump opened 2 years ago

megagrump commented 2 years ago

image

https://en.wikipedia.org/wiki/Amateur_radio_call_signs#Formation_of_an_amateur_radio_call_sign

hirschan commented 2 years ago

Thanks, will fix immediately

megagrump commented 2 years ago

Also here: https://en.wikipedia.org/wiki/Piano_key_frequencies

image

hirschan commented 2 years ago

Good catch - I have fixed now and will upload later, please let me know if you find more tables. I think it's best to keep this issue open so more tables can be linked here.

The issue with tables is that they have td elements and I cannot override all tdelements to dark because that would mess up some other tables, for example this one here would be completely dark: https://es.wikipedia.org/wiki/King_Crimson#Miembros_pasados and also temperature tables with colors would be replaced with dark.

megagrump commented 2 years ago

Sure, I'll gladly complain about anything that isn't as perfect as it should be! lol

Thanks for the effort and I commend your taste in music too if you like King Crimson.

hirschan commented 2 years ago

It should be fixed now, included in the latest update. Haha actually I don't listen to King Crimson - I just remember some user linking me it when I messed up the table colors ;)

HanatakeYurii commented 2 years ago

I have found something similar, not exactly tables but same problem with half of the text unreadable due to bad contrast: https://en.wikipedia.org/wiki/Emperor_Monmu firefox_llrPQ9thhM https://en.wikipedia.org/wiki/Mineral_(nutrient) firefox_AaXtGCwdW4

hirschan commented 2 years ago

Great, thank you! Will try to fix.

HanatakeYurii commented 2 years ago

Another occurrence in another particular case implying special characters (phonological): https://en.wikipedia.org/wiki/Affricate firefox_47FaKQR5Hd As you can (not) see some characters are black on black thus not showing. I can see them by highligthing

hirschan commented 2 years ago

Yeah I noticed that too, seems like some changes became overridden. Will look into this soon!

HanatakeYurii commented 2 years ago

Thanks

hirschan commented 1 year ago

List of other tables I found (adding them here to keep an eye of them) https://en.wikipedia.org/wiki/The_Economist_Democracy_Index#By_region https://en.wikipedia.org/wiki/2024_United_States_presidential_election#Forecasts https://en.wikipedia.org/wiki/London#Climate

Korb commented 3 months ago

Before using the extension: 2024-07-10_20-32-59 After using the extension: 2024-07-10_20-32-35 https://en.wikipedia.org/wiki/XCOM#Released

Dark Mode for Wikipedia 4.5.7 (July 7, 2024) Mozilla Firefox 129.0b1 (64-bit)