search

hirschan / Dark-Mode-Wikipedia

A Firefox extension, primarily suited for the English Wikipedia site.
https://addons.mozilla.org/firefox/addon/dark-mode-for-wikipedia/
MIT License
39 stars 8 forks source link

Blanks on pages when using certain Firefox features #41

Closed MDawg957 closed 12 months ago

MDawg957 commented 1 year ago

This is a minor thing I've been noticing with the extension for over a year but when using this with the Foxy Gestures extension in Firefox, if you do any gesture nav on Wikipedia, it blanks out the page. It clears up as soon as you stop doing any gesture nav, but on any normal website, this does not happen. Not sure what it would take to fix this.

MDawg957 commented 1 year ago

I noticed this problem also happens when you use the built-in screenshot feature in Firefox. Right-click and then choosing Take Screenshot causes a blanking out the Wikipedia page you're on.

image

hirschan commented 12 months ago

Thank you for submitting, will investigate! 👀

hirschan commented 12 months ago

I noticed this problem also happens when you use the built-in screenshot feature in Firefox. Right-click and then choosing Take Screenshot causes a blanking out the Wikipedia page you're on.

image

Found issue, I forgot to add element: iframe as excluded from dark coloring. Will include in 4.5.0 update 🚀

hirschan commented 12 months ago

Can you explain how this Foxy Gestures work? How can I reproduce your bug? Any commands? I barely know what it is.

MDawg957 commented 12 months ago

Can you explain how this Foxy Gestures work? How can I reproduce your bug? Any commands? I barely know what it is.

Foxy Gestures is gesture navigation for your browser. So like I can hold down the right mouse button to activate and then drag to my left and it takes me back a previous page. Same to the right would take me forward. They have multiple commands and you can make your own custom ones, but the idea is just being able to do what you want in the browser with your mouse and not clicking in the UI.

I noticed this problem also happens when you use the built-in screenshot feature in Firefox. Right-click and then choosing Take Screenshot causes a blanking out the Wikipedia page you're on. image

Found issue, I forgot to add element: iframe as excluded from dark coloring. Will include in 4.5.0 update 🚀

Confirmed as fixed. Thank you for being so quick about looking at these!

hirschan commented 12 months ago

Can you explain how this Foxy Gestures work? How can I reproduce your bug? Any commands? I barely know what it is.

Foxy Gestures is gesture navigation for your browser. So like I can hold down the right mouse button to activate and then drag to my left and it takes me back a previous page. Same to the right would take me forward. They have multiple commands and you can make your own custom ones, but the idea is just being able to do what you want in the browser with your mouse and not clicking in the UI.

I noticed this problem also happens when you use the built-in screenshot feature in Firefox. Right-click and then choosing Take Screenshot causes a blanking out the Wikipedia page you're on. image

Found issue, I forgot to add element: iframe as excluded from dark coloring. Will include in 4.5.0 update 🚀

Confirmed as fixed. Thank you for being so quick about looking at these!

Thank you for explaining, I found the issue :) I'll update soon again to fix Foxy Gesture compatibility for 4.5.1, missed canvas element!