[Feature Request] Make it available from addons.mozilla.org

hirschan / Dark-Mode-Wikipedia

A Firefox extension, primarily suited for the English Wikipedia site.

MIT License

39 stars 8 forks source link

Open bat999 opened 10 months ago

bat999 commented 10 months ago

Hi This addon works OK for me with Android Firefox-Beta using a "Custom Add-on collection". Please fix it to work with addons.mozilla.org (AMO). Info is here ---> https://blog.mozilla.org/addons/2023/08/10/prepare-your-firefox-desktop-extension-for-the-upcoming-android-release/

hirschan commented 10 months ago

Thank you for submitting - will have a look!

hirschan commented 10 months ago

Let's keep this issue open and monitor it. Checklist from the link:

Update your manifest.json background key and add “persistent”: false -> not using this property
Ensure listeners are registered synchronously at the top-level -> not sure about this one? Since we're using addEventListener() which I think is async, however I'm not running any background javascript
Record global state in the storage API, for example storage.session -> not using any storage
Change timers to alarms -> not using any timers
Switch from using extension.getBackgroundPage for calling a function from the background page, to extension messaging or runtime.getBackgroundPage -> not using .getBackgroundPage

hirschan commented 10 months ago

I think there is one thing I need to do: when updating extension, include "For Android" option. I'll remind myself to do it in near future!

hirschan commented 7 months ago

I think there is one thing I need to do: when updating extension, include "For Android" option. I'll remind myself to do it in near future!

I'll have a look at this soon. Quite busy with work and life right now.

hirschan commented 4 months ago

[ ] Investigate how to test web extension on Android device and verify that it works
[ ] Update web extension so it can be released it on Android devices (config)