Replace dynamic requires with static ones to not break webpack

hisco / http2-client

Transparently make http request to both http1 / http2 server.

https://www.npmjs.com/package/http2-client

MIT License

33 stars 14 forks source link

Replace dynamic requires with static ones to not break webpack #21

Closed simon-neusoft closed 4 years ago

simon-neusoft commented 4 years ago

I had issues using this package together with webpack, because of the dynamic/programmatic requires. I'm not really sure what setModules is trying to accomplish, but hope this is ok.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 79

5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 78.913%

Totals
Change from base Build 78:	0.03%
Covered Lines:	338
Relevant Lines:	396

💛 - Coveralls

1999 commented 3 years ago

@hisco hey, could you please publish this version in NPM? This issue is actually pretty annoying :(