http2-client doesn't work in Node 12

hisco / http2-client

Transparently make http request to both http1 / http2 server.

https://www.npmjs.com/package/http2-client

MIT License

33 stars 14 forks source link

http2-client doesn't work in Node 12 #30

Closed pimterry closed 3 years ago

pimterry commented 4 years ago

As far as I can tell, this project doesn't work at all in node 12.

I'm testing with Node 12.18.3 (the current node LTS release), and all HTTP/2 requests are never successfully sent to the server.

Easy to reproduce: npm test for this project fails, with every http2 test timing out.

Any ideas why? Happy to help get this fixed, but pointers in the right direction would be very useful!

MikeRalphson commented 4 years ago

Could be related to https://github.com/Mermade/oas-kit/issues/244 - if so, the regression was introduced in Node 12.17.0, and though a similar regression was fixed in the Node 14.x line, it hasn't yet been backported to 12.x

pimterry commented 4 years ago

@MikeRalphson spot on, thanks! I can confirm the tests pass fine in Node 12.16, but just not 12.17+. Eugh.

Is there a Node bug somewhere documenting the underlying issue?

MikeRalphson commented 4 years ago

I don't think anyone's tracked down the 'bad' commit or its revert yet. It would probably take some bisecting.

MikeRalphson commented 4 years ago