Possible solution for http1 sockets staying open - Githubissues

hisco / http2-client

Transparently make http request to both http1 / http2 server.

https://www.npmjs.com/package/http2-client

MIT License

33 stars 14 forks source link

Possible solution for http1 sockets staying open #8

Closed hisco closed 5 years ago

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 37

6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 78.522%

Totals
Change from base Build 35:	0.6%
Covered Lines:	324
Relevant Lines:	381

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 37

6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 78.522%

Totals
Change from base Build 35:	0.6%
Covered Lines:	324
Relevant Lines:	381

💛 - Coveralls

MikeRalphson commented 5 years ago

Yes, this fixes the issue raised in #6 for both my current test cases! Thanks!

hisco commented 5 years ago

Sure, thank you for notifying!