Closed davidak closed 6 years ago
INSTALL
is pretty much Autoconf-generated boilerplate, tons of projects have this file autogenerated with this same contents. They are correct for tarball releases, so it's okay to keep them like that.
Adding separate Github-oriented instructions in the README is a better idea.
With autoconf 2.69 just running autoconf i get this errors:
It doesn't stop configure
from being generated, right? These messages are generally harmless.
It does stop the build with Nix since there are errors:
[davidak@X230:~/code/nixpkgs]$ nix-env -i dit -f ~/code/nixpkgs/
replacing old 'dit-0.4'
installing 'dit-0.4'
these derivations will be built:
/nix/store/scp19d4kh03xk5i98xkzidy6mc1k7zz1-dit-0.4.drv
building '/nix/store/scp19d4kh03xk5i98xkzidy6mc1k7zz1-dit-0.4.drv'...
unpacking sources
unpacking source archive /nix/store/h66hxbm6yx4dn8nqfa6d9c3rjy7sb6gs-source
source root is source
patching sources
configuring
configure.ac:7: error: possibly undefined macro: AM_CONFIG_HEADER
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
configure.ac:8: error: possibly undefined macro: AM_INIT_AUTOMAKE
configure.ac:12: error: possibly undefined macro: AM_PROG_CC_C_O
configure.ac:42: error: possibly undefined macro: AC_MSG_ERROR
builder for '/nix/store/scp19d4kh03xk5i98xkzidy6mc1k7zz1-dit-0.4.drv' failed with exit code 1
error: build of '/nix/store/scp19d4kh03xk5i98xkzidy6mc1k7zz1-dit-0.4.drv' failed
Can you remove the errors? Then i can test the build on darwin.
Just double-checking: do you have Automake installed when that runs? These errors are not appearing here.
I see you are installing dit-0.4
: running from the tarball shouldn't require running autogen.sh
or re-generating the configure
script.
Also, I just uploaded the dit 0.5 tarball, please use that instead:
https://hisham.hm/dit/releases/0.5/dit-0.5.tar.gz
Thank you!
@hishamhm i tried with Automake and libtool and other things, but got the same errors. So it would be helpful to know what additional dependencies are needed for generating the configure script.
I see you are installing dit-0.4
no, i use the latest commit from github. just not changed the version yet.
0.5 release is great. i will test and package it! Will you update the Changelog?
oh, I haven't mantained a Changelog for Dit like ever. I could do that for the next release, yeah!
Closing this one since the instructions in the README were updated and the autoconf issues are unrelated.
Thanks for your interest in Dit :) It's a project I use daily and really enjoy, but it seems that very few people know about (unlike htop), so sometimes it seems to me that no one else uses it!
INSTALL
says "the shell command `./configure && make && make install' should configure, build, and install this package."That might apply to a release from the website, but not for the source released on Github. So we might want to get this in sync? Or at least document the release workflow in README.
configure
don't exists, Autoconf is needed to create it.With autoconf 2.69 just running
autoconf
i get this errors: