Solaris 11 compatibility

hishamhm / htop

htop is an interactive text-mode process viewer for Unix systems. It aims to be a better 'top'.

GNU General Public License v2.0

5.84k stars 581 forks source link

Solaris 11 compatibility #914

Open senjan opened 5 years ago

senjan commented 5 years ago

This PR aims to address 2 issues with htop on current Solaris: 1) htop does not build because Solaris's sys/sysinfo.h defines CPU_KERNEL which collides with definition within htop 2) when run in a Non-Global Zone, kstat module "zones" is not available thus kstat_lookup() returns NULL making htop to crash due to NULL pointer dereference in SolarisProcessList_readZoneName().

senjan commented 5 years ago

fixed missing symbol when building on Linux

ghost commented 5 years ago

Thanks, @senjan - good catch. Keeping track of changes on both illumos and Oracle Solaris can be quite a chore. Contributions are always appreciated!

dodona2 commented 5 years ago

is supporting an outdated OS really that important?

RobCrowston commented 5 years ago

@dodona2 Solaris 11.4 is only nine months old. There are still pockets of industry users out there.

natoscott commented 4 years ago

Merged here: htop-dev/htop@b30c22d (though I renamed the somewhat cryptic "CPU_KRNL" to "CPU_SYSTEM")