search

hissingshark / retrOSMCmk2

RetroPie installer for OSMC on the RPi, Vero4k/4K+ and the VeroV
GNU General Public License v2.0
34 stars 7 forks source link

fix #21: app-switcher.fifo permissions to work around protected_fifos #22

Closed markferry closed 1 year ago

markferry commented 1 year ago

Recent kernels (4.19+) "disallow open of FIFOs ... not owned by the user in world writable sticky directories" See https://kernelnewbies.org/Linux_4.19#Security

hissingshark commented 1 year ago

Yesterday I tried using the add-on for the first time in weeks and encountered this stall at launch. I suspected a FIFO issue from previous experience. I'll have a look at this, but I think you'll be on the money with what you've done.

hissingshark commented 1 year ago

Yes, you've nailed it here. Thanks for doing the legwork. I'll need to merge it into my dev branch before it goes out in master.

Looking at this I've become aware that the last few updates I'd worked on didn't get pushed to master, so haven't been offered as updates to users. No idea why. It's been such a slow year for my coding I can't remember if I was holding them back while I checked something...

mbarnes commented 1 year ago

@hissingshark Just checking if you intend to merge this soon. I don't even see it on the dev branch yet. Can confirm the patch works; I had to fork this repo to get the OSMC launcher working again.