histb-mainline / linux

Linux mainline kernel fork for various HiSilicon Hi3716 / Hi3796 / Hi3798 devices
Other
11 stars 5 forks source link

clk: hisilicon: add CRG driver for Hi3798MV200 SoC #6

Closed 185264646 closed 1 year ago

185264646 commented 1 year ago

Add CRG driver for Hi3798MV200 SoC. CRG(Clock and Reset Generator) module generates clock and reset signals used by other module blocks on SoC. It is similar to HI3798CV200. Note that there are many clocks not being documented and implemented yet, such as cipher, OTP, GPU etc..

yangfl commented 1 year ago

1 introduces fully declarative framework for hisi clocks and can easily cover this patch.

yangfl commented 1 year ago

Merged into #1

185264646 commented 1 year ago

1 introduces fully declarative framework for hisi clocks and can easily cover this patch.

Do you think it really gains by implementing a hi3798 generic driver? I'm in favor of putting crg drivers in separate files actually, just like what rockchip or msm did.

185264646 commented 1 year ago

Merged into #1

I'm not in a hurry, this is just a draft. For review purpose only. We still have much to do.

yangfl commented 1 year ago

Currently we only need focusing on hisi clock framework reimplantation which is required by subsystem maintainer somehow. Whether clocks for variants should be in different files can be discussed later.