histfitter / histfitter

Other
12 stars 16 forks source link

RBF Interpolation with scipy update #86

Open gregbarbour opened 3 years ago

gregbarbour commented 3 years ago

Hi Experts,

I have been using harvestToContours.py recently. I notice that the scipy.interpolate.Rbf is used in harvestToContours.py.

https://github.com/histfitter/histfitter/blob/18f66178a93321c121097dcf91465eb854c30cc1/scripts/harvestToContours.py#L577-L592

In the docs for scipy there is a note saying this code is legacy and a new class RBFInterpolator should be used https://docs.scipy.org/doc/scipy/reference/generated/scipy.interpolate.Rbf.html#scipy.interpolate.Rbf

Are there plans to change to this here as well?

Thank You!

matthewfeickert commented 3 years ago

@gregbarbour I'm not a @histfitter/developers but I would guess that they would welcome a PR if you wanted to give this a go. :slightly_smiling_face: