histogrammar / histogrammar-python

Python implementation of Histogrammar, a package for creating histograms with Numpy, Pandas and Spark.
https://histogrammar.github.io/histogrammar-docs/
Apache License 2.0
33 stars 11 forks source link

Add ascii method #22

Closed ab-10 closed 7 years ago

ab-10 commented 7 years ago

I have implemented an ascii method similar to that in Scala version of histogrammar. Ascii prints out to console a histogram of Bin.

In my implementation I created two helper methods and by doing so attempted to make the implementation more modular. Please let me know if this is not the design pattern you would like me to use.

jpivarski commented 7 years ago

Actually, I was too quick to accept that pull request. See #23, which corrects several points.