search

historical-data / schema

Microdata schema for historical data.
historical-data.org
30 stars 4 forks source link

clarify the inheritance of properties of HistoricalEvent from Event #11

Closed stoicflame closed 12 years ago

stoicflame commented 12 years ago

This pull request clarifies which properties of Event are inherited and which ones are new to HistoricalEvent.

NatAtGeni commented 12 years ago

Same comment here that I made on the inheritance of properties of HistoricalPerson from Person. I think if we make a modification, it's no longer inherited from Event and is instead a property unique to HistoricalEvent.

RobertGardner commented 12 years ago

However, since the Schema.org spec allows you to put a HistoricalPerson in place of a Person, you could argue that it's still an "Event" property.

All we really want is a nice, clear way to indicate that we want a HistoricalPerson here, not a Person. I don't much care how it's resolved! Someone clever can probably figure out a great way to indicate this. :-)

stoicflame commented 12 years ago

The one thing that I don't understand is why do we need to require a HistoricalPerson or HistoricalEvent in the properties values? Are we saying that a Person or Event would be invalid? Why? What if someone wants to put in a (presumably living) person or "regular" event as a value? Why would that we wrong?

NatAtGeni commented 12 years ago

I wanted to require HistoricalPerson and HistoricalEvent rather than Person and Event because Person and Event are being used elsewhere on the web for a different purpose.

stoicflame commented 12 years ago

(Woops. Didn't mean to close the request.)

Person and Event are being used elsewhere on the web for a different purpose.

What purpose other than identifying persons and events? And why would that purpose conflict with the purpose of the property?

NatAtGeni commented 12 years ago

People and Events are being used to markup events that you can attend, buy tickets for, etc and people you can follow on Twitter, friend on Facebook, call on the phone, etc. That's not our purpose here. If we start mixing up HistoricalPeople and HistoricalEvents with People and Events, how will a genealogy-specific search engine/application be able to sort out the two and be able to return relevant results?

stoicflame commented 12 years ago

If we start mixing up HistoricalPeople and HistoricalEvents with People and Events, how will a genealogy-specific search engine/application be able to sort out the two and be able to return relevant results?

Your question assumes that "events that you can attend, buy tickets for, etc and people you can follow on Twitter, friend on Facebook, call on the phone, etc." are not "relevant" in a document. I'm asking: why not?

RobertGardner commented 12 years ago

Other than the above, LGTM.

ninjudd commented 12 years ago

I'd like to see a preview of this and #10 on your gh-pages before merging them.

stoicflame commented 12 years ago

Since there seems to be anxiety about not restricting the range of attendees, subEvents, superEvent, etc., I'm submitting the change at f54c94e.

You can see it here:

http://familysearch.github.com/historical-data.org/HistoricalEvent.html

Note the separate section of overridden properties. I think it clears things up a bit.

What do you think? Can I apply this?

NatAtGeni commented 12 years ago

I like this much better than including the overridden properties in the inherited section. I think it's much clearer.

ninjudd commented 12 years ago

This looks good.