histrio / py-couchdb

Modern pure python CouchDB Client.
https://pycouchdb.readthedocs.org/
Other
120 stars 43 forks source link

all_docs raises excpetion if some documents are not found #38

Closed bmihelac closed 9 years ago

bmihelac commented 10 years ago

I would expect that not found items not to be present in list. Failing testcase is on the way.

refs #36

bmihelac commented 10 years ago

Exception is as follows:

............E..........................................
======================================================================
ERROR: test_all_404 (__main__.DatabaseQueryTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests.py", line 296, in test_all_404
    include_docs='false')
  File "/Users/bmihelac/dev/django/tmp/py-couchdb/pycouchdb/client.py", line 399, in all
    return list(_iterate_no_docs())
  File "/Users/bmihelac/dev/django/tmp/py-couchdb/pycouchdb/client.py", line 394, in _iterate_no_docs
    doc = {"id": row['id'], "rev": row['value']['rev']}
KeyError: 'id'

----------------------------------------------------------------------
histrio commented 9 years ago

Hello, Bojan. This problem is still relevant?

histrio commented 9 years ago

@bmihelac This problem is still relevant?

krisb78 commented 9 years ago

I believe I fixed this in:

https://github.com/histrio/py-couchdb/commit/b49240eed98258690ad8e4d9b3247269f7e8c007

bmihelac commented 9 years ago

All tests pass now. Sorry for late reply.

bmihelac commented 9 years ago

Tests rebased for master.

histrio commented 9 years ago

Thanks, Bojan.