Handle non-existent docs in `all`.

histrio / py-couchdb

Modern pure python CouchDB Client.

https://pycouchdb.readthedocs.org/

Other

120 stars 43 forks source link

Handle non-existent docs in `all`. #45

Closed krisb78 closed 9 years ago

krisb78 commented 9 years ago

Do not process the results of a call to _all_docs, leave it for the wrapper that a user may pass in if they so wish. This prevents the all method from breaking when called with non-existent keys.
Fix tests accordingly.

niwinz commented 9 years ago

This seems to be a breaking change, I'm right?

krisb78 commented 9 years ago

I guess you might consider it a breaking change, but it gives the user more flexibility. The way couchdb iteself handles calls to the _all_docs view is well thought-out and handles all the possible scenarios. I didn't think it was right to hide that from the user.