hitachienergy / epiphany

Cloud and on-premises automation for Kubernetes centered industrial grade solutions.
Apache License 2.0
138 stars 107 forks source link

Add tests to epiphany-wrapper-poc #1502

Closed mkyc closed 4 years ago

mkyc commented 4 years ago

Is your feature request related to a problem? Please describe. Current version (0.0.1) of epiphany-wrapper-poc does not have any tests.

Describe the solution you'd like Implement resonable amount of tests.

Describe alternatives you've considered No alternatives.

Additional context None.

plirglo commented 4 years ago
mkyc commented 4 years ago

@plirglo first point is ok, but second is not :) If you watched demo I've been doing yesterday we do not have epiphany itself moved to docker components so I cannot test it. It is also not interest of that wrapper if docker container it started can do its job correctly or not. This wrapper only focuses on running containers in the way they should be started and react on their exit codes.

plirglo commented 4 years ago

So end-to-end test should contains: running container and check if exit code meets expected one, correct?

mkyc commented 4 years ago

Yeah. Something like this.

mkyc commented 4 years ago

PR in remote repo created: https://github.com/mkyc/epiphany-wrapper-poc/pull/1

This PR introduces:

There are unit tests and integration tests which start with make build and then tests application as separate binary.

mkyc commented 4 years ago

FYI, repo is moved to epiphany organisation and that means that it will not build until naming is fixed there.

mkyc commented 4 years ago

Testing depends on #1572

przemyslavic commented 4 years ago

There are 77 test cases prepared. To execute the tests, run the command make test The tests have been integrated into the CI/CD pipeline and are triggered by PRs.