Closed cicharka closed 2 years ago
Important:
setting value for kubelet enable-controller-attach-detach
parameter shouldn't be done via modifying ansible/playbooks/roles/kubernetes_node/templates/kubeadm-join-node.yml.j2
file - see info from https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/:
(DEPRECATED: This parameter should be set via the config file specified by the Kubelet's --config flag. See kubelet-config-file for more information.)
Therefore we should move that flag to the configuration which is templated by ansible/playbooks/roles/kubernetes_master/templates/kubeadm-config.yml.j2
file.
Is your feature request related to a problem? Please describe. Initialization of Kubernetes worker node in Epiphany with
kubeadm join
is settingenable-controller-attach-detach
kubeletExtraArgs parameter tofalse
while default value provided by kubernetes istrue
. That value, when set tofalse
is blocking attach-detach controller from rook-ceph to attach volume to the pod on worker node, and therefore blocking pod from being created and used.Describe the solution you'd like. While it can be changed manually, it should be possible to configure
enable-controller-attach-detach
parameter by users when creating the cluster withepicli
.Feature should include also change in documentation about that parameter, and information about its mandatory value for
Block Device
andShared Filesystem
storage type.Note: this change is needed only if user want to setup rook-ceph storage type of
Block Device
andShared Filesystem
. If user wants to useObject Storage
value of that flag doesn't have to be changed.While testing ensure that change in
enable-controller-attach-detach
is not affecting any other features provided in Kubernetes by Epiphany.Additional context See
ansible/playbooks/roles/kubernetes_node/templates/kubeadm-join-node.yml.j2
for the template file used forkubeadm join
. That file should include change to parse from input manifest value forenable-controller-attach-detach
set by user.Solves problem described here: https://github.com/epiphany-platform/epiphany/issues/3184
More about controller-attach-detach: https://kubernetes.io/docs/reference/command-line-tools-reference/kubelet/ https://www.alibabacloud.com/blog/getting-started-with-kubernetes-%7C-storage-architecture-and-plug-ins_596307
DoD checklist