hitachienergy / epiphany

Cloud and on-premises automation for Kubernetes centered industrial grade solutions.
Apache License 2.0
138 stars 107 forks source link

[FEATURE REQUEST][download-requirements] Add mechanism to use manifest's configuration/image-registry doc to download wanted images #3260

Closed sbbroot closed 2 years ago

sbbroot commented 2 years ago

Is your feature request related to a problem? Please describe. Currently we filter images in such way:

  1. If there is no configuration/image-registry doc filter images based on used features.
  2. If there is configuration/image-registry doc then ignore filtering and download everything in that doc.

Such mechanism is confusing and leads to problems

Describe the solution you'd like It would be good to implement a flag such as --use-image-registry-doc so that images would be downloaded explicitly.

Describe alternatives you've considered .

Additional context Current mechanism must be based on a flag used instead of a document check.


DoD checklist

sbbroot commented 2 years ago

Idea changed to implement --full-download flag and remove image-registry doc support.