search

hitcherland / FoundryVTT-Heart

Basic FoundryVTT System for Heart - The City Beneath
Creative Commons Zero v1.0 Universal
8 stars 14 forks source link

Development #29

Closed stuttste closed 2 years ago

stuttste commented 2 years ago

Fleshed out Haunts and Landmarks in this one. Decided to hold off on Delves for now since our session 1 is tomorrow and I don't wanna accidentally break something before then. lol

Noticed you pushed 0.4.7, so merged and changed mine to 0.4.8

stuttste commented 2 years ago

Left out Default Stress on the Landmarks. I'll create an issue on it so we don't forget.

stuttste commented 2 years ago

So I did initially try to add the concept of services directly to haunts. Ran into 2 problems with that. Neither is a show-stopper or anything. Can go that way if you want.

The first issue is probably one of me just not being super familiar with the codebase, but the 'add' functions didn't work like I expected them to. Probably requires a custom one for that I'm guessing. Tried a couple methods, but didn't seem to work correctly. EDIT: I figured this one out. Was able to add the backend data working as proposed. Problem is with display with selectOptions not working; see below comment.

Second, and more important imo, is, if you don't have the service item, you don't have a form to edit it with. If you don't have the form, the Haunt is going to have a listing of entries with double-dropdowns (ie. <a>dicerollicon</a><select>die_size</select><select>resistance</select>). I think that's probably doable, but didn't fit the format across the rest of the app.

Ultimately, up to you how we want to go about it, but just bringing up the thought process that went into it.

stuttste commented 2 years ago

For the life of me, though, I cannot get selectOptions to work correctly for the Haunt object. It seems to be related to me extending the base object, but I can't figure out what I'm doing differently to cause the options list to be undefined. Attempting to just plug and play the {{selectOptions die_sizes selected=<resistances array>.die_size}} just will not work.

EDIT: I found exactly what's causing this. The references to the arrays(die_sizes, resistances, etc) break inside of a handlebars foreach loop. Extract that call from the foreach loop, it works. As soon as you put it back in, it breaks.

EDIT: Got it. Finally found the purpose of the ../ hint in handlebars.

stuttste commented 2 years ago

image

This is the result if we decide to omit the service-level object. Is this the path we want to take? (Ignore the middle "Services" section.) EDIT: Could probably implement an 'edit' button to swap between dropdowns/text versions if we'd like.

hitcherland commented 2 years ago

I think that looks good, we also need a "delete" button for the services.

stuttste commented 2 years ago

Perfect. Yep, I'll be sure that's in there as well. Wanted to clear the format with you before continuing. Thanks. Will get another commit posted soonish.

stuttste commented 2 years ago

Ok, committed and reviewed. I think I got everything we mentioned.

stuttste commented 2 years ago

Great! Changes made. Yeah, drag-n-drop is something I wanted to look into at some point too. Mainly, seems like dragging and dropping resources from adversary to characters didn't seem to work when I tried it. Would be a convenient thing to have when DM'ing. Also a 'share'/'send' button for players to give resources to one another.

stuttste commented 2 years ago

You're absolutely right. I hadn't even considered that. Thanks! Should be updated now.