search

hitcherland / FoundryVTT-Heart

Basic FoundryVTT System for Heart - The City Beneath
Creative Commons Zero v1.0 Universal
7 stars 14 forks source link

Show 3d dice for Stress and Fallout rolls if enabled #46

Closed Wigginns closed 1 year ago

Wigginns commented 1 year ago

It would be nice to have an option to show 3d dice (Dice So Nice) for Stress and Fallout rolls. Part of what I really enjoy about using a VTT is that all members of the table can see rolls and experience the drama of them together 😇

Normally, Dice so Nice simply listens for new Rolls that have a new chat message and displays the appropriate roll. Since Heart is implemented to add to or replace existing messages it doesn't trigger Dice So Nice automatically. I believe it would as straightforward as adding an explicit game.dice3d.showForRoll to the FalloutRoll.render call.

P.s. I'd be interested in contributing myself but as a JS amateur I was unable to sort out exactly how to get the dependencies installed in a way that allowed for a webpack build without errors. If you have time to detail a step by step for local dev I'd be interested 😄

Wigginns commented 1 year ago

Ok. After walking away from it for a bit and trying again I figured out I had the wrong command with webpack 😅

Opened a PR that I've tested and verified works as I expect for the above. Included settings to make each type above optional. https://github.com/hitcherland/FoundryVTT-Heart/pull/47

hitcherland commented 1 year ago

Thanks for your PR, that's added to 0.5.1!