Localisation reorganisation + basic support for Polish

hitcherland / FoundryVTT-Heart

Basic FoundryVTT System for Heart - The City Beneath

Creative Commons Zero v1.0 Universal

7 stars 14 forks source link

Localisation reorganisation + basic support for Polish #70

Closed Robak132 closed 3 months ago

Robak132 commented 4 months ago

Breakdown of the changes

merged localisation files to one file in static/lang, resolves #69
changes in the localisation tags, some was unified, renamed all tags to meaningful text (no beat.0, beat.1 etc.)
added Polish support for sheets, GUI, and rolls (without compendiums, they will be added later)

Bonus changes that I can remove if you don't want them

changed webpack module to allow hot-reloading in development mode
changed compendium building from yaml to json dumps of each element in it (thanks to fvtt module)
reverted symbolic link script from /dist to FoundryVTT/Data/systems/heart

Robak132 commented 4 months ago

@hitcherland @Wigginns please give your opinion on changes in webpack building if you want me to remove them

hitcherland commented 4 months ago

This looks like you put a lot of work into it, thank you very much! I'm not at my testing computer right now, but once I have it up and running I'll just check for myself that nothing weird has happened.

Robak132 commented 4 months ago

I would add one more change, re-add beats grouping by ancestry in localisation tags.

Robak132 commented 4 months ago

Ok, everything should be working. @hitcherland You may test my changes now.

hitcherland commented 4 months ago

It occurs to me that renaming translation items is going to absolutely ruin backward compatability unless we add some migration tooling.

Robak132 commented 4 months ago

Should be fixed now. JS is not my first language, so I'm not very familiar with import vs require vs import().

Robak132 commented 3 months ago

@hitcherland I'm in progress of translating compendiums and I found some issues with current state of compendium localisation in this system:

You cannot search by name in compendiums/search anywhere (because the key is real name, localisation is done only on render)
The description of abilities resets to key after edit (and not goes back because <p> tags are automatically added)

Will you consider switching current system to based on Babele module (this solution is used with great success in modules and systems like Warhammer Fantasy 4ed). I can prepare some proof of concept if you want, if not I will try to adapt current system.

Also I fixed scripts so I will be grateful for feedback.

hitcherland commented 3 months ago

hey, sorry for the slow response. There's now a heck of lot of things happen in this review. I'd really prefer if you could chunk this up into smaller pieces. I have also done the work of merging the /lang/.json into central files, so you could start with just the polish translation.

After that I'm happy to start looking into the rest, with the note that I'll probably start looking into a good way to do inter-version updates to make sure users don't lose data.

Robak132 commented 3 months ago

Ok, I'm closing this MR and I'll open another with only Polish translations.