search

hitcherland / foundryvtt-dynamic-macro-links

Allows Dynamic Entity Links to call macros in Foundry VTT
1 stars 3 forks source link

Not working with Module Monk's Enhanced Journal #4

Open Kallimeister opened 2 years ago

Kallimeister commented 2 years ago

Tested @PlayOnlyPlaylist. Worked with Monk's Enhanced Journal deactivated. With Enhanced Journal active clicking Link does nothing.

hitcherland commented 2 years ago

From a quick glance, I think these are now conflicting modules, as they both modify TextEditor.

Here's the sequence:

  1. Dynamic Macro Links modifies _onClickContentLink in the TextEditor class to handle custom links
  2. Monk's Enhanced journal overwrites _onClickContentLink to add Scene transitions from journals
  3. Dynamic Macro Links changes are lost

Sadly, this is a strict limitation of the way FoundryVTT has implemented _onClickContentLink . I used to be able to modify one of the CONST variables to add link support for arbitrary values, but they locked the array (rightly so).