search

hitchtest / hitchselenium

Plugin to run Selenium with firefox using the Hitch testing framework.
GNU Affero General Public License v3.0
1 stars 2 forks source link

Add should_not_appear functionality #4

Closed geokala closed 8 years ago

geokala commented 8 years ago

From docstring: Note that this makes use of 'wait_to_appear', and so if the item in question takes longer to appear than wait_to_appear takes to time out then it will be considered not to have appeared.

I've tried to make it pep8 compliant, but haven't linted the file as a lot of the rest of it will fail.

I've copied the step_library.py (where the change is) into my environment with hitchselenium (0.4.9) and observed it working, so it at least is possible for it to work, but I've not conducted more exhaustive tests.

crdoconnor commented 8 years ago

Looks awesome, thanks for the addition @geokala!

Am not particularly bothered about PEP8. If I go through and clean it up for this project I'll do it all in one go.

One last thing - would you mine signing the CLA?: https://www.clahub.com/agreements/hitchtest/hitch

geokala commented 8 years ago

Signed.

geokala commented 8 years ago

Signed.

crdoconnor commented 8 years ago

Merged and pushed to pypi. Should be usable now just by running "hitch install hitchselenium==0.5.2".

Thanks @geokala !