search

hitenSharm / Discord-Meme-and-Music-Bot

This is a meme and music bot made with NodeJS and DiscordJS
4 stars 4 forks source link

Bug in insult feature #11

Closed hitenSharm closed 3 years ago

hitenSharm commented 3 years ago

Sometimes a text related bug happens. image Maybe if we change this to Discord MessageEmbed this will not happen. Whatever the case, change it to MessageEmbed so that it looks better.

rish78 commented 3 years ago

I would like to work on this issue. But I am rather new to discord bots, so I'll need some guidance, especially on how to set up the bot on my local machine.

hitenSharm commented 3 years ago

It's not that difficult. Take a look at the readme for the setup and take a look at articles online regarding Discord bot tokens. Make sure to have your node at the latest(not the latest stable) version(V16 as of now). If you wish to contact me, then take a look at my website!

rish78 commented 3 years ago

Yup, thanks! I was able to set it up locally. I think I would like to try my hands out on the issue. Could you assign it to me please?

rish78 commented 3 years ago
  1. Although the user does get tagged in the insult, they do not receive any pings. As far as I could find there is no way to ping a user tagged in an embedded message.
  2. The text bug persisted even after using MessageEmbed. So I used the .replace() method to replace the escape characters with their actual characters.

I have created PR #15 with these changes. Please review.