hiteshchoudhary / chai-backend

A video series on chai aur code youtube channel
5.34k stars 803 forks source link

Subscription controllers #81

Open GRajKumar2512 opened 10 months ago

GRajKumar2512 commented 10 months ago

i am not sure whether these controller functions are at there correct place:

const router = Router();
router.use(verifyJWT); // Apply verifyJWT middleware to all routes in this file

router
  .route("/c/:channelId")
  .get(getSubscribedChannels)
  .post(toggleSubscription);

router.route("/u/:subscriberId").get(getUserChannelSubscribers);

because in the controllers files: getSubscribedChannels is fetching the subscriberId and getUserChannelSubscribers is fetching the channelId

AdityaChaudhary3 commented 10 months ago

Yes, When I am working on it. I also saw this problem. So, then we can change them as our requirement. But, It is good to raise this issue for future concern. Will it affect other functions or not? please update here. If I find one I will update.

SaunakNandi commented 9 months ago

Can't you include the getSubscribedChannels inside the post() method as a middleware.

anurag2169 commented 4 months ago

I have update the subscription router and now it is working as excepted:

updated code 👍🏼

router .route("/c/:channelId") .get(getUserChannelSubscribers) .post(toggleSubscription);

// router.route("/u/:subscriberId").get(getUserChannelSubscribers); router.route("/u/:subscriberId").get(getSubscribedChannels);