DLV-322: add new carriers

hitmeister / api-sdk-php

Kaufland.de Onlineshop (former real.de and Hitmeister) API SDK for PHP

https://www.real.de/api/v1/

MIT License

24 stars 29 forks source link

DLV-322: add new carriers #88

Closed BenediktGeiger closed 4 years ago

coveralls commented 4 years ago

Coverage remained the same at 93.263% when pulling 73413c51230454685892397aac9ec89829da3340 on DLV-322_add_new_carriers into 20e13947229cee748c8c42a66bfbfab71077f49d on develop.

mansurs commented 4 years ago

As far as I remember, the versioning of the SDK should stay in sync with versioning of the API. I think we need to change here only the minor number...

BenediktGeiger commented 4 years ago

Hey @mansurs , thx for replying so fast. I have here a corresponding PR on shop side. --> https://gitlab.real-digital.de/real/shop/-/merge_requests/15125/diffs

Since the changes are no Bugfixes (adding new carriers is a minor feature ) and I have changes on "both" sides (shop and api) I assumed that the "Minor" should stay in sync or?

mansurs commented 4 years ago

Aah alright! That looks good then 👍

The 1.39.0 was wrong the previously... It was an only-SDK-feature, so had to be 1.38.1.