A EAN Value is currently treated as a numeric value when Client will render Uri for GET product-data-status/<ean> call

hitmeister / api-sdk-php

Kaufland.de Onlineshop (former real.de and Hitmeister) API SDK for PHP

https://www.real.de/api/v1/

MIT License

24 stars 29 forks source link

A EAN Value is currently treated as a numeric value when Client will render Uri for GET product-data-status/<ean> call #92

Closed sleipi closed 4 years ago

sleipi commented 4 years ago

When request a Product Data Status for a EAN with a leading 0 (zero) the current code will convert this to numeric representation an remove the leading zero, which cause a 404 response because a unknown or invalid EAN is checked.

Here is a fix. Would be happy to see it in it wild.

Thanks ;)

NastiaNovik commented 4 years ago

@sleipi thank you for your PR:) We already opened one to fix it and it is in the review, will be out soon;)

coveralls commented 4 years ago

Coverage remained the same at 93.263% when pulling 30048ba168906f662af7aa48c49219fbd5265034 on jtl-software:ean_as_string into 53bc69b36b1868c36c51d8c46a0335bbb2830fa8 on hitmeister:develop.