search

hitontology / database

Schema, diagram and SPARQL import and export of the HITO software product PostgreSQL database.
Creative Commons Zero v1.0 Universal
2 stars 1 forks source link

DCM4CHE and Medkey citations in Medicator #23

Closed KonradHoeffner closed 3 years ago

KonradHoeffner commented 3 years ago

Medicator has citations Dcm4CheFeatModalityPerformedProcedureStep, Dcm4CheFeatModalityWorklist and MedkeyFeatDashboardVisualAnalytics, this can't be correct.   Please investigate, whether:

  1. Those citation URIs are wrongly named, in this case rename them (the ID only! and please care about the naming conventions, see https://github.com/hitontology/ontology/issues/57)
  2. Those citations URIs don't belong here, in this case change the software product to DCM4CHE, respectively Medkey.

See https://hitontology.eu/database-frontend/softwareproductview/show/Medicator

MichelleBindel commented 3 years ago

I checked them and changed the respective software products, the IDs were correct. Medicator is the default option for the software product, i guess thats why they slipped into Medicator. Thanks for catching that @KonradHoeffner!

KonradHoeffner commented 3 years ago

Thanks for fixing it @MichelleBindel!

This kind of error could be detected automatically, I am thinking about creating a dashboard and quality check tool like we have for the SNIK project at:

snik-qualitycheck snik-dashboard

The links above may not initially load correctly due to CORS errors, in Firefox they work after installing the CorsE extension and enabling it:

Care to not have that active all the time as it weakens browser security.

What do you think, do you have some metrics and possible errors in mind?

The tool would work on the SPARQL endpoint level, so it would lag behind the database and still show errors that have been fixed there but not yet been merged into the endpoint, but other than that I could imagine that being useful.