search

hitranonline / hapiest

A GUI frontend which allows manipulation and processing of data from the HITRAN database.
http://hitran.org/
Other
31 stars 9 forks source link

Hapiest crashes when editing cross-sections filter #46

Closed zrohde2 closed 5 years ago

zrohde2 commented 5 years ago

No cross section filters can be applied because the program crashes. Last lines in terminal read:

WARNING: Traceback (most recent call last): File "src/widgets/cross_section_fetch_widget.py", line 110, in __on_apply_filters_clicked self.set_cross_section_list_items(xsc_filter.get_cross_sections()) File "src/data_structures/xsc.py", line 74, in get_cross_sections if self.molecule_id not in CrossSectionMeta.molecule_metas: AttributeError: type object 'CrossSectionMeta' has no attribute 'molecule_metas' Abort trap: 6

Am I just not doing something correctly?

jkarns275 commented 5 years ago

Nope this is a bug! I'll push a fix in a little while.

jkarns275 commented 5 years ago

Ok I just pushed a fix for this, it should work now. Can you confirm the fix worked?

zrohde2 commented 5 years ago

Confirmed. Program no longer crashes.

On Jul 2, 2019, at 2:04 PM, Josh Karns notifications@github.com wrote:

Ok I just pushed a fix for this, it should work now. Can you confirm the fix worked?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hitranonline/hapiest/issues/46?email_source=notifications&email_token=AMQHPEIHOC7JR2ERFSACQQLP5OKBZA5CNFSM4H46DQ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZCC7LQ#issuecomment-507785134, or mute the thread https://github.com/notifications/unsubscribe-auth/AMQHPEOSB4PG3AT4ZSAB6ADP5OKBZANCNFSM4H46DQ5Q.

jkarns275 commented 5 years ago

Great! Will close this issue for now.