hitrust / google-app-engine-django

Automatically exported from code.google.com/p/google-app-engine-django
Apache License 2.0
0 stars 0 forks source link

[Enhancement] Support for running from under /lib/ #121

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I tend to like putting all my third party dependencies under /lib/ in my
django applications. However, doing this will break ./manage.py and
similar, as they assume that app.yaml will be in the same directory as
appengine_django, but instead they're on directory up.

Attached is a patch which will support checking the parent directory for
app.yaml, as well as giving a more helpful error message if there's no
app.yaml to be found

(Patch is against svn trunk)

Original issue reported on code.google.com by gagrav...@gmail.com on 8 Apr 2009 at 2:23

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the patch, it looks like a reasonable concept. 

You could consider using a pattern such as the one used to find the SDK at
http://code.google.com/p/google-app-engine-django/source/browse/trunk/appengine_
django/__init__.py#84
to avoid having branches in your if statement that do nothing other than 
"pass". I
think this would make the code somewhat clearer.

Please also see the README and ensure that you have completed the CLA signing
requirements.

Original comment by mattbrow...@gmail.com on 17 Apr 2009 at 5:05