hitsub / CookieAssistant

Assist tool for Cookie Clicker Steam Edition
MIT License
21 stars 15 forks source link

allow setting interval period for the action to perform after autosell #79

Closed cheatfreak47 closed 2 years ago

cheatfreak47 commented 2 years ago

the auto sell change in 7.0 made it so it now waits the autosell interval before trying to buy back buildings, and then sells them again after it hits it again....

This means you can no longer sell and instantly buy back your buildings, instead you'd need to set it to 5s (5000ms) or more so it just so happens to work out mathematically. This kind of sucks because it means half the time you lose the CPS from the buildings you sold

instead, the interval setting for auto sell should be specifically auto sell only, and then we should have a second interval for how long to wait after selling before we perform the second action (usually buy back)

an example of how this should work:

AutoSell Buildings On: [Inverval 10010ms (~10-seconds)]
   Sell Cursors for 830 when Always
       Do After Activated: Buy Back the Amount Sold [Interval 200ms (~1/5sec)

in this example, this would mean, every 10010ms it would try to auto sell the amount of buildings and then, 200ms after the sell action, it would try to buy the amount sold back

instead as of now, I have to do this to achieve the closest to the same result

AutoSell Buildings On: [Inverval 5020ms (~5-seconds)]
   Sell Cursors for 830 when Always
       Do After Activated: Buy Back the Amount Sold 

which results in every 5020ms it either sells buildings OR buys them back depending on what it did previously, and every devastation buff, I lose all the extra cursor CPS for half of the buff time :(

cheatfreak47 commented 2 years ago

and yes, if you just want to abuse the buff, this is still possible under my proposal here as well as long as good timings are set, a likely example of how to abuse it under my proposal: (buy, then sell as soon as possible, and as soon as the sale happens, buy again)

AutoSell Buildings On: [Interval 80ms]
 Sell Blah for Blah when Always
        Do After Activated: Buy Back the Amount Sold [Interval 40ms]
  Sell Blah for Blah when Always
        Do After Activated: Buy Back the Amount Sold [Interval 40ms]
  Sell Blah for Blah when Always
        Do After Activated: Buy Back the Amount Sold [Interval 40ms]
hitsub commented 2 years ago

Sorry, I can't understand the meaning of what you wrote.

This means you can no longer sell and instantly buy back your buildings, instead you'd need to set it to 5s (5000ms) or more so it just so happens to work out mathematically. This kind of sucks because it means half the time you lose the CPS from the buildings you sold

The auto sell feature works even if the interval is set to 1ms.

This works:

  1. sell the building
  2. buy back them
  3. wait interval time
  4. return to number 1

This works very powerfully to get the Godzamok buff. What is the problem?

cheatfreak47 commented 2 years ago

it doesn't work as you describe in the current release, right now it appears to work like this:

  1. sell the building
  2. wait the interval time
  3. buy back the building
  4. wait the interval time again
  5. return to number 1

if I wanted to make the buff work once every 10 seconds (right after the buff runs out), with the buyback happening instantly after selling to regain cps as soon as possible, I can't do that right now because it waits the interval twice, if I set the interval to 10 seconds, it would take 20 seconds to get back to the sell because it waits the 10 seconds before buying too

cheatfreak47 commented 2 years ago

my idea is to keep it like this, but to add an seperate interval option for the buy back (or any second action) so that you can make more complex logic here if you want as a player

hitsub commented 2 years ago

Sorry, you're right. This feature wait interval time each operation.

However, the Devastation buff is added every time the building is sold. There is no need to wait for the buffing to finish before selling. The shorter the interval, the more powerful the buff will be. (The display will not change, but the CPC multiplier will be added internally.)

I think no any advantage in being able to adjust intervals.

cheatfreak47 commented 2 years ago

It's not really about advantage, it's more about letting the user have more control? What if I don't want to exploit it and I just want to apply the buff as a normal person would, once every 10 seconds as soon as it runs out? At the moment the only way I have to do it that way kind of sucks.

Allowing the interval to be selected would allow someone with relatively fewer cookies to allow cookies to build up from the buff before trying to spend cookies to buy them back, this is obviously not a problem mid-to-late-game but early game if you get the pantheon quickly, it could be a nice option. It also is good if you have other auto-buy things spending lots of cookies, it might allow you to prevent running into situations where it can't afford to buy them back.

Buying and selling hundreds of buildings on 1ms interval isn't even close to humanly possible, so it's kind of cheating, and that's okay, but not everyone wants to use CookieAssistant to cheat. Many people (like myself) use it just to make the game more of a complete idle game.

cheatfreak47 commented 2 years ago

I would definitely agree that it should be hidden behind "Show All Interval Settings" but while we're on that, I don't really think it needs to be justified anyway, I mean, what benefit is there in setting an interval for clicking the sugar lump, for example? None that I can think of, but the option still exists. More options is nice. :)

hitsub commented 2 years ago

Ok, I understand your point probably. Thanks for the explanation.

The reason why some Interval settings are hidden is because I think they are unnecessary, and the button to show them is for people who have edited with the values in past versions.

Even if prepare complex options, only a small percentage of people will use it. What needs to be done is not to provide complex options, but to fix the current unintuitive Interval settings.

hitsub commented 2 years ago

This function is not easy to understand, but it is closed because of its low priority.