Refactoring startup scripts - Githubissues

hitsz-ids / duetector

duetector🔍: Data Usage Extensible Detector for data usage observability.

https://dataucon.idslab.io/

Apache License 2.0

10 stars 8 forks source link

Refactoring startup scripts #78

Closed kayo09 closed 1 year ago

kayo09 commented 1 year ago

Added user entrypoint Removed jupyterlab dependency

Description

Motivation and Context

dependency on jupyterlab is removed

How has this been tested?

testing is not thorough

Types of changes

[ ] Maintenance (no change in code, maintain the project's CI, docs, etc.)
[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

wunder957 commented 1 year ago

Hi, thanks for bringing up the first PR!

Just wanna remind you:

The name of the PR should indicate the main work of this PR
In best practice, your branch name should be meaningful as well, such as kayo09:start-sctipt

I've changed the title and checklist for this PR, and in the markdown, the checklist surrogate is using [*]

wunder957 commented 1 year ago

I believe this PR isn't perfect yet, so I'd set it to draft first, and when you're ready, you can click Ready for review !