Closed MooooCat closed 5 months ago
Authors of pull request: @MooooCat, @pre-commit-ci[bot]
Renamed the class SynthesizerModel
to StatisitcSynthesizerModel
to reflect a more descriptive class name.
Sweep Found These Issues
StatisitcSynthesizerModel
contains a typo and should be corrected to StatisticSynthesizerModel
.Updated the fit
method to use Metadata
and DataLoader
, changed the base class to StatisitcSynthesizerModel
, and modified the column validation process.
Sweep Found These Issues
fit
method now requires metadata
and dataloader
arguments, which could cause issues if these are not provided or are incorrectly formatted.fit
method now depends on DataLoader
and Metadata
objects, which could introduce bugs if these objects are not correctly instantiated or if their methods do not behave as expected.Added support for StatisitcSynthesizerModel
in the Synthesizer
class and removed the unpacking of model_fit_kwargs
in the fit
method.
Sweep Found These Issues
model_fit_kwargs
in the fit
method call could omit important parameters that influence the model fitting process.Sweep isn't 100% sure if the following are issues or not but they may be worth taking a look at.
**(model_fit_kwargs or {})
in the fit
method could omit important parameters that influence the model fitting process, potentially leading to unexpected behavior or reduced functionality.Updated the test_gaussian_copula
function to use new metadata and data loader fixtures, and refactored the GaussianCopulaSynthesizer
instantiation and fit method calls accordingly.
Sweep isn't 100% sure if the following are issues or not but they may be worth taking a look at.
discrete_cols
assignment to model.discrete_cols
is incorrect as discrete_cols
is a generator and not directly accessible.discrete_cols
assignment to model.discrete_cols
is incorrect as discrete_cols
is a generator and not directly accessible.fix done
Description
Motivation and Context
How has this been tested?
Types of changes
Checklist: