Question about the crop

hityzy1122 / opencv_transforms_torchvision

opencv reimplement for transforms in torchvision

MIT License

193 stars 29 forks source link

Closed SWHL closed 3 years ago

SWHL commented 3 years ago

Thank your work.
I think the order of X and Y in the crop function is reversed, in the following code: https://github.com/YU-Zhiyang/opencv_transforms_torchvision/blob/33c26803eaea1ec7d51953c9f0f58c80bd6d72ba/cvtorchvision/cvtransforms/cvfunctional.py#L280
I think it should be:
```
return img[y1:y2, x1:x2, ...].copy() 
```

SWHL commented 3 years ago

I misunderstood, yours is correct