search

hityzy1122 / opencv_transforms_torchvision

opencv reimplement for transforms in torchvision
MIT License
193 stars 29 forks source link

Update README.md #7

Closed Nikronic closed 5 years ago

Nikronic commented 5 years ago

Fixing minor typos and grammatical problems and change paths to relative links. Also, formatting implemented methods using ` mark.

Nikronic commented 5 years ago

@YU-Zhiyang I did not check the implementation yet; are those bold functions implemented?

hityzy1122 commented 5 years ago

Fixing minor typos and grammatical problems and change paths to relative links. Also, formatting implemented methods using ` mark.

Thank you very very very much!

hityzy1122 commented 5 years ago

@YU-Zhiyang I did not check the implementation yet; are those bold functions implemented?

Yes, and the bold functions are additional methods which do not exist in the official torchvision module

Nikronic commented 5 years ago

No problem, thanks for merging the PR. I thought the bolded ones are not implemented yet. So I think it would be better to format them using ` marker too but a * or something like that to demonstrate that they do not exist in the official PyTorch Transforms package. What do you think? @YU-Zhiyang

In the end I think we could set up Github Actions for this repo to make sure any commit is passing tests using CI tools. If you are ok with this, we can follow furthur information in another issue then I can make a PR for that too.

hityzy1122 commented 5 years ago

No problem, thanks for merging the PR. I thought the bolded ones are not implemented yet. So I think it would be better to format them using ` marker too but a * or something like that to demonstrate that they do not exist in the official PyTorch Transforms package. What do you think? @YU-Zhiyang

In the end I think we could set up Github Actions for this repo to make sure any commit is passing tests using CI tools. If you are ok with this, we can follow furthur information in another issue then I can make a PR for that too.

Sorry for the late reply, as I am busy seeking for an opportunity of internship. Thanks for all your advice which makes sense. As I am not so familiar with the Github Action and CI tools, I can't set up it currently, I will have a try when I have time. Thanks again!

Nikronic commented 5 years ago

No problem, I will handle it in issue #8 and make a PR when it is ready.