search

hiukim / mind-ar-js

Web Augmented Reality. Image Tracking, Face Tracking. Tensorflow.js
MIT License
2.19k stars 407 forks source link

fix: too much zoom on multi camera devices for tracking #203

Closed mateusmb closed 1 year ago

mateusmb commented 2 years ago

This PR solves issue #105, where multi camera devices has the default camera selected, which in case is too zoomed in. This doesn't break the camera usage for devices which doesn't have this issue.

hiukim commented 2 years ago

@mateusmb Thanks for the PR. Can you help me understand what are you trying to fix?

I saw you are trying to select a camera with this label whenever possible: "camera2 0, facing back". What's the reason for doing that? Why "camera2 0, facing back" is the best camera?

Sov3rain commented 2 years ago

@hiukim It's a bit of a hacky solution, there is no real answer for "why" as I understand. This is just try and error on Samsung and other multiple lenses phones.

See this issue for more details, as AR,js seems to have the same problem.

JxstWieslaw commented 1 year ago

Hie @hiukim @Sov3rain @mateusmb

hiukim commented 1 year ago

Please refer to this update on how to pick camera: https://github.com/hiukim/mind-ar-js/issues/105#issuecomment-1575478582

Closing this PR. thx all.