search

hiukim / mind-ar-js

Web Augmented Reality. Image Tracking, Face Tracking. Tensorflow.js
MIT License
2.16k stars 399 forks source link

Worker-loader deprecation #250

Closed positlabs closed 1 year ago

positlabs commented 1 year ago

I cloned the project and tried to run npm install but I got this error message about unresolved peer dependencies.

Screen Shot 2022-09-26 at 9 52 46 AM

Looking into it, I discovered that the worker-loader package is deprecated for webpack v5.

Screen Shot 2022-09-26 at 10 14 39 AM

Web workers are available directly in webpack v5, but the catch is that it's only available in module syntax, and not commonjs. https://webpack.js.org/guides/web-workers/

It looks like there's already a ticket for esmodule support, but it hasn't been updated in a while. https://github.com/hiukim/mind-ar-js/issues/63

Since it seems like a big task to solve this issue, I wonder, is there a workaround for this?

positlabs commented 1 year ago

Workaround in PR ^

positlabs commented 1 year ago

No longer needed due to the switch to vite